Clearer hint text for bridge condition

[fenhl]

This makes 2 changes to the text box that gives the rainbow bridge condition as part of the message shown when reading the Temple of Time altar as adult:

• If the “Clearer Hints” setting is enabled, the text is changed from “The awakened ones will await for the Hero to collect” to “The rainbow bridge will be built once the Hero collects”.
  • The text for open bridge is unchanged, since it already mentions the bridge: “The awakened ones will have already created a bridge to the castle where the evil dwells.”
• Regardless of settings, the light arrow icon, which has misled some people into thinking the text was hinting the location of the light arrows, is removed. This is similar to the change made to the child altar text in Rework the ToT altar text to not be misleading and provide more information #1102.

Fixes #1473.

There's something weird going on with the indentation in this text box. Maybe our line wrapping algorithm is getting confused by the previous boxes in this message having icons?

[r0bd0g]

I wonder if that indent is forced by the game, and that's why there was randomly a picture of the light arrows there before. Like I don't think it was put there b/c a picture of the light arrows would be nice, but because some icon had to be used to avoid the weird indent.

[GSKirox]

I don't think this is caused by the line wrap function, i suspect this is a vanilla issue when drawing consecutive textboxes, since i don't see any vanilla textbox that has an icon at first then remove it, they always keep an icon on the left.
So we could either :

• fix this behaviour (probably something in this function https://github.com/zeldaret/oot/blob/main/src/code/z_message_PAL.c#L849 ). Not sure if it's easy.
• or just find a more neutral icon that is less ambiguous. Maybe the master sword ? (control code for the icon should be 3C)

[r0bd0g]

I feel like I remember a discussion about this back when the icons of the medallions were added, long time ago now.

[ETR-BTF]

I don't think this is caused by the line wrap function, i suspect this is a vanilla issue when drawing consecutive textboxes, since i don't see any vanilla textbox that has an icon at first then remove it, they always keep an icon on the left. So we could either :

• fix this behaviour (probably something in this function https://github.com/zeldaret/oot/blob/main/src/code/z_message_PAL.c#L849 ). Not sure if it's easy.
• or just find a more neutral icon that is less ambiguous. Maybe the master sword ? (control code for the icon should be 3C)

How about an "empty" icon that's just a transparent square? Would that be easier to implement?

[GSKirox]

I don't see an easy way to do that, might be easier to just fix it.

[fenhl]

I've added the Master Sword icon for now. I guess we'll have to fix this properly before Master Sword shuffle.

[cjohnson57]

Looks good