forked from AmazingAmpharos/OoT-Randomizer
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve advanced contribution readme and experience #2107
Merged
cjohnson57
merged 6 commits into
OoTRandomizer:Dev
from
flagrama:improve-asm-readme-and-path
Nov 29, 2023
Merged
Improve advanced contribution readme and experience #2107
cjohnson57
merged 6 commits into
OoTRandomizer:Dev
from
flagrama:improve-asm-readme-and-path
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some improvements for helping new contributors get started with the more advanced hacking aspects of the randomizer, and simplifying re-setting up an environment on new hardware/installs for existing contributors. README.md & others: Consistently use Project64's canonical name in documentation. ASM/README.md: Add headers, more detailed instructions on installing the toolchain, including methods described in Discord #dev-resources channels. Also mention a potential issue with trying to use the Project64 symbols on a default install. ASM/build.py: Add additional subdirectories of `tools` to PATH. Makes above instructions simpler. ASM/.gitignore: Ignore everything in the `tools` directory (except .gitkeep as with roms)
fenhl
added
the
Component: Documentation
Affects user-facing help messages or public API docs
label
Oct 5, 2023
Windows: armips requires the VC++ redist installed but doesn't currently provide it. MSYS2 is required for the files prepackaged on dropbox. The rest is mostly stuff people on the affected platforms should be used to so detail is not added.
Mention the compilers required on other platforms for armips as well.
cjohnson57
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good overall, just a couple minor things that I'd like
cjohnson57
added
Status: Waiting for Author
Changes or response requested
and removed
Status: Needs Review
Someone should be looking at it
labels
Nov 13, 2023
Typo and reword previous commit.
cjohnson57
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Documentation
Affects user-facing help messages or public API docs
Status: Waiting for Author
Changes or response requested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements for helping new contributors get started with the more advanced hacking aspects of the randomizer, and simplifying re-setting up an environment on new hardware/installs for existing contributors.
README.md & others: Consistently use Project64's canonical name in documentation.
ASM/README.md: Add headers, more detailed instructions on installing the toolchain, including methods described in Discord #dev-resources channels. Also mention a potential issue with trying to use the Project64 symbols on a default install.
ASM/build.py: Add additional subdirectories of
tools
to PATH. Makes above instructions simpler.ASM/.gitignore: Ignore everything in the
tools
directory (except.gitkeep
as withroms
)2023-10-08: Added some more Windows prerequisites and details on installing MSYS2 and adding its binaries to the path. Also some quick mentions of prerequisites for other platforms.