Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve advanced contribution readme and experience #2107

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

flagrama
Copy link

@flagrama flagrama commented Oct 5, 2023

Some improvements for helping new contributors get started with the more advanced hacking aspects of the randomizer, and simplifying re-setting up an environment on new hardware/installs for existing contributors.

README.md & others: Consistently use Project64's canonical name in documentation.

ASM/README.md: Add headers, more detailed instructions on installing the toolchain, including methods described in Discord #dev-resources channels. Also mention a potential issue with trying to use the Project64 symbols on a default install.

ASM/build.py: Add additional subdirectories of tools to PATH. Makes above instructions simpler.

ASM/.gitignore: Ignore everything in the tools directory (except .gitkeep as with roms)

2023-10-08: Added some more Windows prerequisites and details on installing MSYS2 and adding its binaries to the path. Also some quick mentions of prerequisites for other platforms.

Some improvements for helping new contributors get started with the more advanced
hacking aspects of the randomizer, and simplifying re-setting up an environment
on new hardware/installs for existing contributors.

README.md & others: Consistently use Project64's canonical name in documentation.

ASM/README.md: Add headers, more detailed instructions on installing the toolchain,
including methods described in Discord #dev-resources channels. Also mention a
potential issue with trying to use the Project64 symbols on a default install.

ASM/build.py: Add additional subdirectories of `tools` to PATH. Makes above
instructions simpler.

ASM/.gitignore: Ignore everything in the `tools` directory (except .gitkeep as with roms)
@fenhl fenhl added the Component: Documentation Affects user-facing help messages or public API docs label Oct 5, 2023
@flagrama flagrama marked this pull request as draft October 8, 2023 19:09
Windows: armips requires the VC++ redist installed
but doesn't currently provide it. MSYS2 is required
for the files prepackaged on dropbox.

The rest is mostly stuff people on the affected
platforms should be used to so detail is not added.
@flagrama flagrama marked this pull request as ready for review October 8, 2023 21:48
Mention the compilers required on other platforms for armips as well.
@cjohnson57 cjohnson57 added the Status: Needs Review Someone should be looking at it label Nov 11, 2023
Copy link
Collaborator

@cjohnson57 cjohnson57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall, just a couple minor things that I'd like

ASM/README.md Show resolved Hide resolved
ASM/README.md Outdated Show resolved Hide resolved
@cjohnson57 cjohnson57 added Status: Waiting for Author Changes or response requested and removed Status: Needs Review Someone should be looking at it labels Nov 13, 2023
Typo and reword previous commit.
Copy link
Collaborator

@cjohnson57 cjohnson57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes!

@cjohnson57 cjohnson57 merged commit 85ff26c into OoTRandomizer:Dev Nov 29, 2023
3 checks passed
@fenhl fenhl added this to the 8.1 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Affects user-facing help messages or public API docs Status: Waiting for Author Changes or response requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants