Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TCG key text ID with Key Appearance Matches Dungeon #2192

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Mar 15, 2024

#2019 changed treasure chest game keys to use their vanilla text ID, but the separate item used when the “Key Appearance Matches Dungeon” setting is enabled was missed, resulting in a text ID error. This PR adjusts that item's text ID to fix this.

Tested to verify the issue is fixed:

image

I used the following plando for this test:

{
    "settings": {
        "open_forest": "open",
        "spawn_positions": [
            "child"
        ],
        "starting_tod": "midnight",
        "starting_items": {
            "Magic Meter": 1,
            "Lens of Truth": 1
        },
        "start_with_rupees": true,
        "key_appearance_match_dungeon": true
    },
    "entrances": {
        "Child Spawn -> KF Links House": {
            "region": "Market",
            "from": "Market Treasure Chest Game"
        }
    }
}

@fenhl fenhl added Type: Bug Something isn't working Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it labels Mar 15, 2024
@fenhl fenhl added this to the 8.1 milestone Mar 15, 2024
@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label Mar 15, 2024
@fenhl fenhl merged commit 5067a09 into OoTRandomizer:Dev Mar 15, 2024
3 checks passed
@fenhl fenhl deleted the tcg-key-text branch March 15, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants