Cross out pre-completed dungeons in dungeon info menu #2244
Conversation
|
This should also be displayed on the dungeon info menu (D-left). And I'm not sure it makes sense to gray out the key counts, that kinda implies you're not going to need the keys, which isn't necessarily going to be true in mixed pools bosses or blue warp ER. |
fenhl
added
Type: Enhancement
| @@ -2771,6 +2771,7 @@ def configure_dungeon_info(rom: Rom, world: World) -> None: | |||
| dungeon_rewards[codes.index(area.dungeon_name)] = boss_reward_index(location.item) | |||
|
|
|||
| dungeon_is_mq = [1 if world.dungeon_mq.get(c) else 0 for c in codes] | |||
| dungeon_precompleted = [1 if world.empty_dungeons[c].empty else 0 for c in codes] | |||
There was a problem hiding this comment.
The existing names chosen for pre-completed dungeons seem to be misleading. They aren't empty dungeons, and empty as a property on the dungeon almost looks like a language feature to check if the index in an array is empty.
For clarity maybe these should be renamed to precompleted_dungeons and precompleted?
There was a problem hiding this comment.
I'm not sure the .empty attribute access is needed at all. I think World.empty_dungeons could just be a dict[str, bool] (or maybe even set[str]). I guess this PR is as good a time to change it as any, but it shouldn't be a blocker since it could also be handled in a separate PR. Regarding the name change, the current name matches the internal/plando name for the setting, so it should stay for now imo. Hopefully we can eventually accept #1839 so we can rename it.
GSKirox
force-pushed
the
precompleted_menu
branch
from
f72fb8e
to
359eed4
Compare
|
Rewrote the change with the newly added text printing functions, and added the crossed dungeons to the dpad left menu. |
fenhl
removed
Status: Under Consideration
GSKirox
force-pushed
the
precompleted_menu
branch
from
359eed4
to
8c1a76c
Compare
GSKirox
force-pushed
the
precompleted_menu
branch
from
8c1a76c
to
d22ec0d
Compare
Currently the only in-game way to tell if a dungeon is pre-completed is by comparing the dungeon rewards with the map/compass informations.
This PR adds the ability to tell pre-completed dungeons apart directly in the rando-custom dungeon info menu (A in pause screen).
They will be grayed and crossed out :
This should be fully compatible with side dungeons and Ganon Castle, if they get implemented later as pre-completed valid choices.