Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stick/Nut Upgrade Model Improvements #2313

Open
wants to merge 1 commit into
base: Dev
Choose a base branch
from
Open

Stick/Nut Upgrade Model Improvements #2313

wants to merge 1 commit into from

Conversation

rrealmuto
Copy link

This PR adds a flame/smoke effect to the stick/nut upgrade GI models as shown below.

GLideN64_THE_LEGEND_OF_ZELDA_081
GLideN64_THE_LEGEND_OF_ZELDA_080
GLideN64_THE_LEGEND_OF_ZELDA_079
GLideN64_THE_LEGEND_OF_ZELDA_078

@fenhl fenhl added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Oct 1, 2024
@RawZ06
Copy link

RawZ06 commented Oct 1, 2024

It would be nice to have a same effect for magic meter maybe ?

GSKirox
GSKirox requested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@GSKirox GSKirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of formatting nitpicks

ASM/c/item_draw_functions.h
Comment on lines +55 to +56
void draw_gi_flame(z64_game_t *game, colorRGBA8_t prim, colorRGBA8_t env);
void draw_gi_opa_with_flame(z64_game_t *game, uint32_t draw_id);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
void draw_gi_flame(z64_game_t *game, colorRGBA8_t prim, colorRGBA8_t env);
void draw_gi_opa_with_flame(z64_game_t *game, uint32_t draw_id);
void draw_gi_flame(z64_game_t* game, colorRGBA8_t prim, colorRGBA8_t env);
void draw_gi_opa_with_flame(z64_game_t* game, uint32_t draw_id);

ASM/c/item_draw_functions.c
(-game->gameplay_frames & 0x7F) << 2, 0x20, 0x80));

gSPDisplayList(gfx->poly_xlu.p++, 0x04000000 | kFlameDlist);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@fenhl fenhl added the Status: Waiting for Author Changes or response requested label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSKirox GSKirox GSKirox requested changes

Assignees
No one assigned
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described Status: Waiting for Author Changes or response requested Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rrealmuto @RawZ06 @GSKirox @fenhl