Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Meter Item: Scroll #2340

Merged
merged 4 commits into from
Jan 5, 2025
Merged

Conversation

Maplesstar
Copy link

Learn magic by reading a scroll:
image

Video in a few places, including DMC volcano: https://youtu.be/iZLqd265yHc

Only tested on RA.

@fenhl fenhl added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Testing Probably should be tested Component: Patching Affects the patching of the ROM labels Dec 27, 2024
@fenhl fenhl added this to the next milestone Dec 27, 2024
@TreZc0
Copy link
Member

TreZc0 commented Dec 28, 2024

I like it a lot, i think this is the best out of both worlds.

@cjohnson57 cjohnson57 removed the Status: Needs Testing Probably should be tested label Jan 5, 2025
@cjohnson57 cjohnson57 merged commit 64ed7ff into OoTRandomizer:Dev Jan 5, 2025
3 checks passed
@r0bd0g
Copy link

r0bd0g commented Jan 6, 2025

Did this PR change the item icon on the file select? (Should it have?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Component: Patching Affects the patching of the ROM Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants