Merge pull request #25 from Open-EO/issue16-ruff

Github actions "Lint" workflow: Enable ruff code linter (instead of flake8)

.github/workflows/lint.yaml

@@ -21,10 +21,10 @@ jobs:
     - name: Install Python dependencies
       run: |
         python -m pip install --upgrade pip
-        python -m pip install isort black flake8
+        python -m pip install isort black ruff
     - name: isort
       run: python -m isort . --check --diff
     # - name: black
     #   run: python -m black --check --diff .
-    # - name: flake8
-    #   run: python -m flake8 .
+    - name: ruff
+      run: ruff check .

pyproject.toml

@@ -65,3 +65,15 @@ addopts = [
 
 [tool.isort]
 profile = "black"
+
+
+[tool.ruff]
+# line-length = 100
+
+[tool.ruff.lint]
+select = ["E", "F"]
+ignore = [
+  "E501",  # Ignore "line-too-long" issues, let black handle that.
+]
+
+

src/openeo_gfmap/fetching/s1.py

@@ -7,7 +7,7 @@
 from geojson import GeoJSON
 
 from openeo_gfmap.backend import Backend, BackendContext
-from openeo_gfmap.spatial import BoundingBoxExtent, SpatialContext
+from openeo_gfmap.spatial import SpatialContext
 from openeo_gfmap.temporal import TemporalContext
 
 from .commons import (

src/openeo_gfmap/preprocessing/udf_rank.py

@@ -1,4 +1,3 @@
-from pathlib import Path
 
 import numpy as np
 import xarray as xr

src/openeo_gfmap/preprocessing/udf_score.py

@@ -1,13 +1,10 @@
-import datetime
 import math
-import time
 
 import numpy as np
 import xarray as xr
 from openeo.udf import XarrayDataCube
 from scipy.ndimage import distance_transform_cdt
-from skimage.morphology import binary_dilation, binary_erosion, footprints
-from xarray.ufuncs import isnan as ufuncs_isnan
+from skimage.morphology import binary_erosion, footprints
 
 
 def apply_datacube(cube: XarrayDataCube, context: dict) -> XarrayDataCube:

src/openeo_gfmap/spatial.py

@@ -1,6 +1,6 @@
 """ Definitions of spatial context, either point-based or spatial"""
 from dataclasses import dataclass
-from typing import Dict, Union
+from typing import Union
 
 from geojson import GeoJSON
 

src/openeo_gfmap/temporal.py

@@ -1,7 +1,6 @@
 """ Definitions of temporal context"""
 from dataclasses import dataclass
 from datetime import datetime
-from typing import Tuple
 
 
 @dataclass

src/openeo_gfmap/utils/build_df.py

@@ -2,7 +2,6 @@
 based job. Usefull to collect the output of point based extraction.
 """
 
-from datetime import datetime
 from pathlib import Path
 
 import pandas as pd

src/openeo_gfmap/utils/intervals.py

@@ -2,7 +2,7 @@
 methods.
 """
 
-from datetime import datetime, timedelta
+from datetime import timedelta
 
 from openeo_gfmap import TemporalContext
 

tests/test_openeo_gfmap/test_cloud_masking.py

@@ -1,5 +1,4 @@
 from pathlib import Path
-from typing import Union
 
 import pytest
 

tests/test_openeo_gfmap/test_s2_fetchers.py

@@ -1,10 +1,8 @@
 """ Tests for data extractors for Sentinel2 data. """
 from pathlib import Path
-from typing import Union
 
 import geojson
 import geopandas as gpd
-import numpy as np
 import openeo
 import pytest
 import rioxarray