123 meteo stac #130
Merged
123 meteo stac #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/openeo_gfmap/fetching/commons.py src/openeo_gfmap/fetching/generic.py
There was a problem hiding this comment.
In general:
I'm not a big fan of creating another sub function _load_collection_hybrid as it creates yet another level in the load collection process. I would rather keep it in _load_collection and we could extract some fetch type functionality to other functions. (should keep the code more coherent)
Let me know what you think!
VictorVerhaert
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a separate fetcher to get meteo data from the STAC catalogue when it comes to use the CDSE backends
I made quite some modifications in the fetching functionalities, could you give in a look @VictorVerhaert ?
This also fixes the logger issue in the FeatureExtractor and ModelInference classes