Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rescaling method #134

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Added rescaling method #134

merged 3 commits into from
Jun 20, 2024

Conversation

GriffinBabe
Copy link
Collaborator

@VictorVerhaert an extension of the compress_uint16 method. I had to do a compression to uint8 for worldcereal recently

@GriffinBabe GriffinBabe linked an issue Jun 20, 2024 that may be closed by this pull request
Add a compression method for uint8 #133
Closed
VictorVerhaert
VictorVerhaert approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@VictorVerhaert VictorVerhaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we might want to rename it to a cast method and get the data type as an argument.
For now let's merge this.

@GriffinBabe GriffinBabe merged commit deb5cdd into main Jun 20, 2024
1 check passed
@GriffinBabe GriffinBabe deleted the 133-compression-uint8 branch June 20, 2024 11:04
@GriffinBabe
Copy link
Collaborator Author

Closes #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVerhaert VictorVerhaert VictorVerhaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a compression method for uint8
2 participants
@GriffinBabe @VictorVerhaert