Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed meteo extractor #156

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Removed meteo extractor #156

merged 3 commits into from
Sep 11, 2024

Conversation

GriffinBabe
Copy link
Collaborator

@HansVRP I removed the METEO fetcher as the same functionalities are present in the METEO fetcher

Copy link
Collaborator

@VincentVerelst VincentVerelst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: this does mean we don't support fetching meteo from the openeo STAC API anymore. Should we then maybe add an assertion that if "AGERA5" is selected, only the terrascope backend can be used?

@GriffinBabe
Copy link
Collaborator Author

@VincentVerelst I added the functionality build_generic_extractor_stac to continue supporting stac extraction, and added some checks based on the backend.

From a discussion with @HansVRP we decided that GFMAP shouldn't take too much care of checking if a collection is valid or not in a certain backend but rather instead let the load_collection method raise the exception itself.

@GriffinBabe
Copy link
Collaborator Author

@VincentVerelst can you review this PR ?

@VincentVerelst VincentVerelst merged commit 4e568b0 into main Sep 11, 2024
1 check passed
@VincentVerelst VincentVerelst deleted the delete-meteo-fetcher branch September 11, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants