Include cancelling long running jobs #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
Jul 22, 2024
…tamp. Enable cancelling jobs based on running duration
|
@soxofaan I have worked on the comments above and also included 2 additional unit tests to test the behavior |
soxofaan
reviewed
Jul 26, 2024
soxofaan
reviewed
Jul 26, 2024
Co-authored-by: Stefaan Lippens <[email protected]>
Co-authored-by: Stefaan Lippens <[email protected]>
Co-authored-by: Stefaan Lippens <[email protected]>
Co-authored-by: Stefaan Lippens <[email protected]>
Co-authored-by: Stefaan Lippens <[email protected]>
Co-authored-by: Stefaan Lippens <[email protected]>
Co-authored-by: Stefaan Lippens <[email protected]>
Co-authored-by: Stefaan Lippens <[email protected]>
…-python-client into hv_prolonged_runs
|
Can we merge now? We have some other changes coming up as well on this one. |
|
@soxofaan The issues seems to be resolved |
soxofaan
pushed a commit
that referenced
this pull request
Sep 3, 2024
soxofaan
added a commit
that referenced
this pull request
Sep 3, 2024
|
squashed and merged in 712a6fa 👍 |
soxofaan
added a commit
that referenced
this pull request
Sep 3, 2024
Call public `run_jobs` instead of internal `_track_statuses`. Use a fake backend that interacts with standard requests, instead of mocking internals. Parameterize `cancel_after_seconds` instead of separate test functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included _check_and_stop_long_running_jobs.
Still needs to be covered in test_suite