Issue #288 use DriverVectorCube in apply_polygon #291
+37
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
added a commit
to Open-EO/openeo-geopyspark-driver
that referenced
this pull request
Jun 11, 2024
soxofaan
reviewed
Jun 11, 2024
| @@ -124,7 +124,7 @@ def chunk_polygon( | |||
| reducer: dict, | |||
| # TODO #288:` chunks` should be an explicit collection of geometries (e.g a FeatureCollection, vector cube base class or an iterable of geometries) | |||
| # Note that subclass implementations even wrongly retype this to `MultiPolygon`. | |||
| chunks: Union[shapely.geometry.base.BaseGeometry], | |||
| chunks: DriverVectorCube, | |||
There was a problem hiding this comment.
I'm afraid it's not that easy to change this API like this without being backward compatible.
openeo-geopyspark-driver for example extends this API so we need to create some window for transition
There was a problem hiding this comment.
Isn't it okay to merge this PR together with the one on the geopyspark-driver?
Open-EO/openeo-geopyspark-driver#801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.