Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move handling of umu_version.json to pyproject.toml #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

db47h
Copy link
Contributor

@db47h db47h commented Jul 19, 2024

New build dependency: hatch vcs

Removed the version* targets from the Makefile.

The generated version is more convoluted than before though: "launcher": "0.1rc5.dev234+g9cbd15d.d20240719"

New build dependency: hatch vcs

Removed the version* targets from the Makefile.
@R1kaB3rN
Copy link
Member

R1kaB3rN commented Sep 3, 2024

Great. Also, after working on zipapps, I am now considering to remove umu_version.json from the repo. Instead, we can simply add metadata such as the version to __init__.py. If some of these steps can be automated by hatch, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants