-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: make rule to generate standalone python zipapp application #174
Conversation
Co-authored-by: Denis Bernard <[email protected]>
Co-authored-by: Denis Bernard <[email protected]>
- We do not necessarily have to append to git commit to the file name as we can identify the reproducible build by its digest once we distribute it. Additionally, we can have the launcher log some metadata at runtime for further identification
A review would be appreciated |
- zipapp should be the preferred way when umu is used as a runner for a client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am attaching a patch with the suggested changes to avoid any ambiguities stemming from my review comments. It's just a basis, we can adapt it along with the discussion.
Side note: the makefile has collected some clutter, maybe we should take this opportunity to clean it up a bit too. |
Co-authored-by: Stelios Tsampas <[email protected]>
Co-authored-by: Stelios Tsampas <[email protected]>
Co-authored-by: Stelios Tsampas <[email protected]>
Co-authored-by: Stelios Tsampas <[email protected]>
6a4672c
to
618c6bf
Compare
Co-authored-by: Stelios Tsampas <[email protected]>
@@ -30,4 +31,10 @@ jobs: | |||
sudo make PREFIX=/usr install | |||
- name: Make release | |||
run: | | |||
make release | |||
# TODO: Figure out release without requiring root | |||
sudo make release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the action's log, it is odd that creating a virtualenv results in a permission error, I don't understand why that happens either.
Co-authored-by: Stelios Tsampas <[email protected]>
Co-authored-by: Stelios Tsampas <[email protected]>
Co-authored-by: Stelios Tsampas <[email protected]>
Co-authored-by: Stelios Tsampas <[email protected]>
This reverts commit dce0d49.
- We can't remove this logic yet until both Lutris and Heroic move to zipapps in the next release
Tested on latest stable versions of Lutris (0.5.17) and Heroic (2.15.1) to ensure this change doesn't break them by simply replacing the umu directory contents. Note: For clients who choose to subscribe to zipapps, it will require updating their logic to call
|
Supersedes #149 and closes #148
Fixes user installs by installing umu-launcher as a reproducible zipapp at
$HOME/.local/bin
.Additionally, this feature gives clients another installation option and will come with the advantage of simplifying updates, simplifying client logic, and reducing the likelihood of data corruption.