Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Add tests to operation servers in ruby client #16179

Merged
merged 13 commits into from
Jul 25, 2023
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 25, 2023

  • Add tests to operation servers in ruby client
  • remove valid? (deprecated) from anyof model template

One will need to add the following entries to host table in order to test locally:

127.0.0.1   path.v1.test.openapi-generator.tech
127.0.0.1   path.v2.test.openapi-generator.tech
127.0.0.111 path.v3.test.openapi-generator.tech
127.0.0.1   operation.v1.test.openapi-generator.tech
127.0.0.1   operation.v2.test.openapi-generator.tech
127.0.0.111 operation.v3.test.openapi-generator.tech
127.0.0.1   server.v1.test.openapi-generator.tech
127.0.0.1   server.v2.test.openapi-generator.tech
127.0.0.111 server.v3.test.openapi-generator.tech
127.0.0.1   petstore.swagger.io

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@wing328
Copy link
Member Author

wing328 commented Jul 25, 2023

docker tests failure not related to this change.

@wing328 wing328 merged commit 9aa15d9 into master Jul 25, 2023
12 of 13 checks passed
@wing328 wing328 deleted the ruby-add-tests2 branch July 25, 2023 11:29
@wing328 wing328 added this to the 7.0.0 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant