Remove unused test dependencies org.reflections
& maven-rewrite
#18798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
org.reflections
…is not used anywhere
TestUtils
TestUtils.validatePomXmlFiles(List)
with testsYo, dawg, i heard you like tests, so i wrote some tests for your test helpers 😉 (well really it was to make sure the following step produced runtime behavior)
Although the
RawPom.parse
method implements tight checks by databinding to its own sophisticated pom POJO, it is really only the five assertions inTestUtils.validatePomXmlFiles(List)
that we're after.rewrite-maven
imports a whopping 73 MB onto the classpath with dozens of transitive dependencies having to be gulped by our IDEs – a little overkill just for a single test helper method.org.openrewrite:rewrite-maven
and keepjackson-dataformat-xml
explicitly (was a transitive dependency ofrewrite-maven
)NB: Open Rewrite (big fan here BTW) does not need to be included in the pom in order to use it – one can just use the "Maven command line" option tab on the recipe pages.
All in all, this brings down the number of total dependencies in the
openapi-generator
module from 143 to 105 🚀PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)