Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Golang] Move utility functions from client.mustache to utils.mustache #18802

Closed

Conversation

martinlakov
Copy link
Contributor

Move the newStrictDecoder & reportError utility functions from client.mustache to utils.mustache

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 31, 2024

thanks for the PR

please follow step 3 to update the samples

@martinlakov
Copy link
Contributor Author

@wing328 @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5 - Samples have been re-generated accordingly

@wing328
Copy link
Member

wing328 commented Jun 13, 2024

thanks for the PR. is it correct to say that this PR is a breaking change (without fallback)?

@martinlakov
Copy link
Contributor Author

thanks for the PR. is it correct to say that this PR is a breaking change (without fallback)?

Shouldn't be - it is only moving two utility functions to utils.go. No new additions, no deletions.

This is important when only generating models and no controllers

@wing328
Copy link
Member

wing328 commented Jun 24, 2024

thanks for the explanation. sounds reasonable for the use cases only generating model files.

closed via #19001 with updated samples.

@wing328 wing328 closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants