Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone Schema using AnnotationUtils.clone with WA #18867

Merged

Conversation

dreambrother
Copy link
Contributor

@dreambrother dreambrother commented Jun 5, 2024

Fix for #18052 (comment) @wing328

Getter and setter of Schema's example field works with Object class, this breaks serializer added in #18052. I've replaced it with AnnotationUtils.clone call with some workaround for custom types for schema ver < 3.1 (looks like this method works fine with 3.1 schemas #18052 (comment))

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@dreambrother dreambrother force-pushed the clone-schema-with-example-fix branch 2 times, most recently from da2a39b to eb0b0b7 Compare June 5, 2024 12:28
@dreambrother dreambrother force-pushed the clone-schema-with-example-fix branch from eb0b0b7 to abf61e6 Compare June 5, 2024 12:32
@wing328 wing328 merged commit 3aba427 into OpenAPITools:master Jun 6, 2024
15 checks passed
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
@wing328 wing328 changed the title clone Schema using AnnotationUtils.clone with WA (to clone schemas wi… clone Schema using AnnotationUtils.clone with WA Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants