Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Fix deepObject serialization that are anyOf #19090

Merged

Conversation

tanmaykm
Copy link
Contributor

@tanmaykm tanmaykm commented Jul 5, 2024

Updates the go client generator to have the generated struct for anyOf types conform to MappedNullable interface. Fixes query params serialization for deepObjects that are of anyOf type.

Implements the suggestion in #19085

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @wing328 @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)

@tanmaykm tanmaykm marked this pull request as ready for review July 5, 2024 15:29
@wing328
Copy link
Member

wing328 commented Jul 6, 2024

thanks for the PR

can you please review the test failure when you've time?

https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/30391/workflows/356f8074-0c40-4353-9c03-8a1efa9cdc6a/jobs/98609

@tanmaykm tanmaykm force-pushed the juliahub/fix_go_deepobject_client branch from fc4f38a to fa7588f Compare July 22, 2024 10:12
@tanmaykm
Copy link
Contributor Author

Thanks @wing328 for taking a look.
The test failures are now resolved.

@tanmaykm
Copy link
Contributor Author

Does this look good now @wing328 ?

@wing328
Copy link
Member

wing328 commented Jul 29, 2024

can you please add a test or 2 to modules/openapi-generator/src/test/resources/3_0/go/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml and regenerate the samples?

Updates the go client generator to have the generated struct for anyOf types conform to `MappedNullable` interface.
Fixes query params serialization for deepObjects that are of `anyOf` type.

Implements the suggestion in OpenAPITools#19085
added some tests to `modules/openapi-generator/src/test/resources/3_0/go/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml` and regenerated the samples
@tanmaykm tanmaykm force-pushed the juliahub/fix_go_deepobject_client branch from 2e4dd93 to c8b07f7 Compare July 30, 2024 06:02
@tanmaykm
Copy link
Contributor Author

@wing328 added tests to petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml in c8b07f7

@tanmaykm
Copy link
Contributor Author

tanmaykm commented Aug 2, 2024

@wing328 is there anything else needed?

@wing328
Copy link
Member

wing328 commented Aug 4, 2024

nope. let's give it a try

thanks for the PR

@wing328 wing328 merged commit 4c163fe into OpenAPITools:master Aug 4, 2024
16 checks passed
@wing328 wing328 added this to the 7.8.0 milestone Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants