-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go] Fix deepObject serialization that are anyOf #19090
[Go] Fix deepObject serialization that are anyOf #19090
Conversation
thanks for the PR can you please review the test failure when you've time? |
fc4f38a
to
fa7588f
Compare
Thanks @wing328 for taking a look. |
Does this look good now @wing328 ? |
can you please add a test or 2 to |
Updates the go client generator to have the generated struct for anyOf types conform to `MappedNullable` interface. Fixes query params serialization for deepObjects that are of `anyOf` type. Implements the suggestion in OpenAPITools#19085
added some tests to `modules/openapi-generator/src/test/resources/3_0/go/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml` and regenerated the samples
2e4dd93
to
c8b07f7
Compare
@wing328 is there anything else needed? |
nope. let's give it a try thanks for the PR |
Updates the go client generator to have the generated struct for anyOf types conform to
MappedNullable
interface. Fixes query params serialization for deepObjects that are ofanyOf
type.Implements the suggestion in #19085
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)cc: @wing328 @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)