Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Gradle Enterprise references with Develocity #19264

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jprinet
Copy link
Contributor

@jprinet jprinet commented Jul 29, 2024

Replace Gradle Enterprise references with Develocity

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jprinet
Copy link
Contributor Author

jprinet commented Jul 29, 2024

cc @wing328

@wing328 wing328 merged commit d12cc0b into OpenAPITools:master Jul 29, 2024
16 checks passed
@martin-mfg
Copy link
Contributor

Hi @jprinet,
since this PR was merged the Travis builds are failing.
This seems to be the relevant error:

[ERROR] Extension com.gradle:common-custom-user-data-maven-extension:2.0 or one of its dependencies could not be resolved: Could not find artifact com.gradle:common-custom-user-data-maven-extension:jar:2.0 in google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/)

Do you have an idea why this happens?

@wing328
Copy link
Member

wing328 commented Aug 13, 2024

ran out of travis free credits, i'll request more. thanks for pointing it out

@wing328
Copy link
Member

wing328 commented Aug 14, 2024

@jprinet @martin-mfg about the travis build errors, I've merged to revert the extension version back to 1.x for the time being (and travis ci build passed) before we've time to look into the issue and come up with a fix

@jprinet
Copy link
Contributor Author

jprinet commented Aug 14, 2024

Interesting, I'll take a look

@jprinet
Copy link
Contributor Author

jprinet commented Aug 14, 2024

My understanding is that the Google mirror does not have the dependency:
https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/271877075#L609

Not sure how your repositories are configured on Travis but my guess is that Maven Central is not defined as the dependency can be found in there:
https://mvnrepository.com/artifact/com.gradle/common-custom-user-data-maven-extension/2.0

Can you confirm my assumption? If yes I see 2 options for the resolution:

  • Have Google repo fetching the artifact
  • Configure Maven central as a source repo in Travis

@wing328
Copy link
Member

wing328 commented Aug 14, 2024

looks like this is a similar issue: checkstyle/checkstyle#7444

and it contains a PR with a fix

@jprinet
Copy link
Contributor Author

jprinet commented Aug 14, 2024

Makes sense, although this artifact was published a while ago.
Will you then switch to the Maven central repo?

@wing328
Copy link
Member

wing328 commented Aug 14, 2024

Have Google repo fetching the artifact

that's one way to do it but I've no idea how

@jprinet
Copy link
Contributor Author

jprinet commented Aug 14, 2024

me neither

@wing328
Copy link
Member

wing328 commented Aug 14, 2024

i'll give it a try with the fix mentioned in checkstyle/checkstyle#7444 this weekend (or next)

@wing328 wing328 added this to the 7.8.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants