Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aspnetcore] Fix swagger xml comments #19593

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

david-marconis
Copy link
Contributor

This fixes issue #19592. Tested by building and applying the fix to the example given in the issue and verified working.
Steps ran from the failure state in the issue (present in sibling directory, hence ../):

java -jar ../openapi-generator/modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g aspnetcore -i openapi.yaml
dotnet test src/Org.OpenAPITools.Tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Sep 19, 2024

thanks for the PR

let's give it a try

@wing328 wing328 merged commit eebecc8 into OpenAPITools:master Sep 19, 2024
27 checks passed
@wing328 wing328 added this to the 7.9.0 milestone Sep 19, 2024
@wing328 wing328 changed the title [aspnetcore] Fix issue #19592 regarding swagger xml comments [aspnetcore] Fix swagger xml comments Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants