-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix export types for typescript client (#6805) #19616
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -5,6 +5,7 @@ | |||||||||||||||||||||||||||||||||
.travis.yml | ||||||||||||||||||||||||||||||||||
DESCRIPTION | ||||||||||||||||||||||||||||||||||
NAMESPACE | ||||||||||||||||||||||||||||||||||
README.md | ||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems like the sort ordering is not kept stable across systems for this one There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, probably because the samples were generated on a windows machine There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the problem lies here: Lines 1984 to 1999 in 849b3e8
There is some code to make the output platform-independent, however the sorting happens BEFORE, on the original paths with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you fix it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. trying already. Always tricky to do non-platform specific things with platform-specific objects :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||||||||||||||||||||||||||
R/allof_tag_api_response.R | ||||||||||||||||||||||||||||||||||
R/animal.R | ||||||||||||||||||||||||||||||||||
R/any_of_pig.R | ||||||||||||||||||||||||||||||||||
|
@@ -39,7 +40,6 @@ R/user.R | |||||||||||||||||||||||||||||||||
R/user_api.R | ||||||||||||||||||||||||||||||||||
R/whale.R | ||||||||||||||||||||||||||||||||||
R/zebra.R | ||||||||||||||||||||||||||||||||||
README.md | ||||||||||||||||||||||||||||||||||
docs/AllofTagApiResponse.md | ||||||||||||||||||||||||||||||||||
docs/Animal.md | ||||||||||||||||||||||||||||||||||
docs/AnyOfPig.md | ||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please manually revert to
/
, as this is the standard for linux-based systems