Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to specify triggers for Zapier #19638

Closed
wants to merge 7 commits into from

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 22, 2024

based on #18814 with updated samples

cc @valmoz, @emajo

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title Marketplace software zapier triggers23 make it easier to specify triggers for Zapier Sep 22, 2024
@wing328 wing328 added this to the 7.9.0 milestone Sep 22, 2024
@wing328 wing328 changed the title make it easier to specify triggers for Zapier Make it easier to specify triggers for Zapier Sep 22, 2024
@wing328 wing328 marked this pull request as ready for review September 22, 2024 06:30

const actions = {
const operations = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-wallen is this a breaking change? shall we keep the const name as actions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep the name. Also we need to drop the commit that says (EM Only)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

435c73d this might be the commit that you want to land on it's own. You could start from this PR #19643.

Sorry that I can't generate the samples on my computer. Git Bash generates the wrong path separator on Windows...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I was also able to update the samples properly by using the devcontainer in 86307de!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

i merged via #19645

in which you're listed as co-author

thanks again for the PR

@wing328 wing328 closed this Sep 23, 2024
@wing328 wing328 deleted the MarketplaceSoftware-zapier_triggers23 branch September 23, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants