Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4brunu feature/swift6b #19641

Closed
wants to merge 20 commits into from
Closed

4brunu feature/swift6b #19641

wants to merge 20 commits into from

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 22, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 mentioned this pull request Sep 22, 2024
5 tasks
@wing328
Copy link
Member Author

wing328 commented Sep 22, 2024

@wing328
Copy link
Member Author

wing328 commented Sep 24, 2024

@4brunu all tests passed.

Will merge it tomorrow if no further feedback from anyone.

@4brunu
Copy link
Contributor

4brunu commented Sep 24, 2024

I don't know why initially CI was not running on #19621, but now it is running

@wing328
Copy link
Member Author

wing328 commented Sep 24, 2024

I don't know why initially CI was not running on #19621, but now it is running

I updated the setting in bitrise.io to trigger the workflow when there's a change to the new folders for swift6 samples.

here are the folders/paths that will trigger a build when there's change:

samples/client/petstore/swift5/**

samples/client/petstore/swift-combine/**

samples/client/petstore/swift6/*

@wing328 wing328 closed this Sep 28, 2024
@wing328 wing328 deleted the 4brunu-feature/swift6b branch September 28, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants