Scala cask api effects #19936
Merged
Scala cask api effects #19936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixe for grouped methods which have routes containing dashes.
Previously our OperationGroup work-around would potentially
Create methods like ‘foo-bar’, which isn’t a valid function name
* Fix to not import some.package.Array[Byte] when binary format is specified
* Fix for grouped operations which contain duplicate query parameters
* Fix for binary response fields. This can come up with the following example
"responses" : {
"200" : {
"content" : {
"application/json" : {
"schema" : {
"format" : "binary",
"type" : "string"
}
}
},
"description" : "data"
},
* Fix for enum model classes
Extracted complex logic for ‘asData’ and ‘asModel’ transformations for properties
* Introduced a generic effect F[_] for services
This was done to support composable services
(Service A calls Service B) by using monadic
Effect types (ones which can flatMap)
* Fixed unique union types for responses, asModel and asData fixes for non-model types
aaronp
force-pushed
the
scalaCaskAPIEffects
branch
from
c5f0dff
to
987f9c9
Compare
|
thanks for the PR can you please review the CI errors when you've time? |
|
Absolutely - I'm on it 👍
…On Tue, Oct 22, 2024 at 5:08 AM William Cheng ***@***.***> wrote:
thanks for the PR
can you please review the CI errors when you've time?
—
Reply to this email directly, view it on GitHub
<#19936 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMIOPRZBV3GSNIVE2FBY3Z4XFSDAVCNFSM6AAAAABQKWXNXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRYGE4DKNJTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
let me know if you need help to fix these errors |
|
Will do - thanks! I am doing some fixes - apologies the PR is taking a while
…On Fri, Nov 1, 2024 at 7:54 AM William Cheng ***@***.***> wrote:
Error: Forbidden method invocation:
java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default
locale]
Error: in org.openapitools.codegen.languages.ScalaCaskServerCodegen
(ScalaCaskServerCodegen.java:771)
let me know if you need help to fix these errors
—
Reply to this email directly, view it on GitHub
<#19936 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMIOLHEMWK4ARUNKZAJ4DZ6MXUJAVCNFSM6AAAAABQKWXNXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRGQ3DEOBVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala-Cask fixes to:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)