Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor copy lambda #19983

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Oct 27, 2024

The copy lambda had a hard coded command that mutated the cached value. That was giving me an issue in another PR I'm working on. I removed that, and I also moved the white space handling from paste to copy. The reason for that change is that the way we handle white space will depend on how the copy is written. For example, these two will produce different results. Therefore, we should handle the white space correctly in the copy lambda where it occurs, not later in the paste.

{{#lambda.copy}}foo{{/lambda.copy}}

{{#lambda.copy}}
foo
{{/lambda.copy}}

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Oct 30, 2024

@devhl-labs
Copy link
Contributor Author

done

@wing328 wing328 merged commit f98073d into OpenAPITools:master Nov 6, 2024
15 checks passed
@wing328 wing328 added this to the 7.10.0 milestone Nov 6, 2024
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Nov 6, 2024
@devhl-labs devhl-labs deleted the refactor-copy-lambda branch November 6, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants