-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Docker Compose for Enhanced Development Experience #251
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are some good changes. However, as mentioned in my specific comments I think it shouldn't run the web app by default. I looked into adding this functionality but there were a couple errors. I'll look into it more when I have some free time. Otherwise it's a good addition to the project! Let me know of your thoughts on my aforementioned points!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes, just a slight redundancy with the .env.sample. Just leave it as .env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
this is a bad idea, most .gitignores should have .env by default. having .env.sample or even sample.env would be good to have, legit for the long run. When your running in production or development environments for teams and such. |
This is a good point, but I've never seen an env.sample or sample.env used personally. the environment can just be defined in the documentation |
Well this isn't for the actual environment its more for storage in the repo, and then we add the different .env production.env, etc into the gitignore. This way we can just use |
Yeah, alright sure! I don't really mind it's a minor thing. |
Laravel (docs) is a good example of .env.example (in their case) where the official instruction is to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is stimulating to see all your chats, however there are some conflicts between your work and chatdev in Experiential Co-Learning function, we are looking forward that these conflicts are solved.
Please fix the conflicts |
ca5aa3d
to
21c6372
Compare
This pull request introduces Docker Compose to the existing Docker setup:
docker-compose.yml
file to simplify container orchestration and environment setup.wiki.md
to guide users on utilizing Docker Compose and the flexibility it offers, such as changing the defaultonline_log/app.py
.This PR aim to further enhance the developer experience, making it easier for new users to get started.
Feedback and testing are welcome.