36: Now uses latest 3.1.8r5 datamodels for VRP and Funds Conf #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the VRP controllers are not yet in place, the following issue alluded to problems with the swagger generation;
OpenBankingToolkit/openbanking-aspsp#421
A newer version (3.1.8r5) of the swagger files are available and I have regenerated the datamodels, and the VRP controllers from this swagger spec.
This PR only adds the new model changes to the openbanking-uk-datamodel and changes all components to use the new models. ASPSP required some changes to convert the new Funds Conformation classes to FR classes for storage.
Issue: OpenBankingToolkit/openbanking-toolkit#36