Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFAPP-1368] PIS legacy test case and consent id match #147

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[REFAPP-1368] PIS legacy test case and consent id match #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions manifests/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,27 @@
"Risk": {}
}
},
"minimalInternationalPaymentConsentV4": {
"body": {
"Data": {
"Initiation": {
"InstructionIdentification": "$instructionIdentification",
"EndToEndIdentification": "$endToEndIdentification",
"CurrencyOfTransfer": "$currencyOfTransfer",
"InstructedAmount": {
"Amount": "$instructedAmountValue",
"Currency": "$instructedAmountCurrency"
},
"CreditorAccount": {
"SchemeName": "$internationalCreditorScheme",
"Identification": "$internationalCreditorIdentification",
"Name": "$internationalCreditorName"
}
}
},
"Risk": {}
}
},
"minimalInternationalPayment": {
"body": {
"Data": {
Expand All @@ -460,6 +481,28 @@
"Risk": {}
}
},
"minimalInternationalPaymentV4": {
"body": {
"Data": {
"ConsentId": "$OB-400-DOP-101600-ConsentId",
"Initiation": {
"InstructionIdentification": "$instructionIdentification",
"EndToEndIdentification": "$endToEndIdentification",
"CurrencyOfTransfer": "$currencyOfTransfer",
"InstructedAmount": {
"Amount": "$instructedAmountValue",
"Currency": "$instructedAmountCurrency"
},
"CreditorAccount": {
"SchemeName": "$internationalCreditorScheme",
"Identification": "$internationalCreditorIdentification",
"Name": "$internationalCreditorName"
}
}
},
"Risk": {}
}
},
"minimalInternationalScheduledPaymentConsent": {
"body": {
"Data": {
Expand All @@ -483,6 +526,29 @@
"Risk": {}
}
},
"minimalInternationalScheduledPaymentConsentV4": {
"body": {
"Data": {
"Permission": "Create",
"Initiation": {
"RequestedExecutionDateTime": "$requestedExecutionDateTime",
"InstructionIdentification": "$instructionIdentification",
"EndToEndIdentification": "$endToEndIdentification",
"CurrencyOfTransfer": "$currencyOfTransfer",
"InstructedAmount": {
"Amount": "$instructedAmountValue",
"Currency": "$instructedAmountCurrency"
},
"CreditorAccount": {
"SchemeName": "$internationalCreditorScheme",
"Identification": "$internationalCreditorIdentification",
"Name": "$internationalCreditorName"
}
}
},
"Risk": {}
}
},
"minimalInternationalScheduledPayment": {
"body": {
"Data": {
Expand All @@ -506,6 +572,29 @@
"Risk": {}
}
},
"minimalInternationalScheduledPaymentV4": {
"body": {
"Data": {
"ConsentId": "$OB-400-DOP-102000-ConsentId",
"Initiation": {
"RequestedExecutionDateTime": "$requestedExecutionDateTime",
"InstructionIdentification": "$instructionIdentification",
"EndToEndIdentification": "$endToEndIdentification",
"CurrencyOfTransfer": "$currencyOfTransfer",
"InstructedAmount": {
"Amount": "$instructedAmountValue",
"Currency": "$instructedAmountCurrency"
},
"CreditorAccount": {
"SchemeName": "$internationalCreditorScheme",
"Identification": "$internationalCreditorIdentification",
"Name": "$internationalCreditorName"
}
}
},
"Risk": {}
}
},
"OBFundsConfirmationConsent1": {
"body": {
"Data": {
Expand Down
29 changes: 4 additions & 25 deletions manifests/ob_4.0_payment_fca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,27 +567,6 @@
"schemaCheck": true,
"validateSignature": true
},
{
"description": "Fails when NumberOfPayments, FinalPaymentDateTime are specified at the time.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 doesn't have such fields anymore

"id": "OB-400-DOP-1015001",
"refURI": "https://openbankinguk.github.io/read-write-api-site3/v4.0/profiles/payment-initiation-api-profile.html",
"detail": "Checks if NumberOfPayments, FinalPaymentDateTime are specified at the time.",
"parameters": {
"tokenRequestScope": "payments",
"paymentID": "$OB-400-DOP-101401-DomesticStandingOrderID"
},
"uri": "/domestic-standing-orders/$paymentID",
"uriImplementation": "conditional",
"resource": "DomesticScheduledPayment",
"asserts_last_if_all": [
"OB3GLOAssertNumberOfPayments",
"OB3GLOAssertFinalPaymentDateTime",
"OB3GLOAssertOn403"
],
"method": "get",
"schemaCheck": true,
"validateSignature": true
},
{
"description": "Fails when NumberOfPayments, FinalPaymentDateTime are not specified and FinalPaymentAmount is specified.",
"id": "OB-400-DOP-1015002",
Expand Down Expand Up @@ -620,7 +599,7 @@
"OB-400-DOP-101600-instructionIdentification": "$instructionIdentification",
"instructionIdentification": "$fn:instructionIdentificationID()",
"endToEndIdentification": "e2e-internat-pay",
"postData": "$minimalInternationalPaymentConsent",
"postData": "$minimalInternationalPaymentConsentV4",
"requestConsent": "true"
},
"body": "$postData",
Expand Down Expand Up @@ -672,7 +651,7 @@
"currencyOfTransfer": "$currencyOfTransfer",
"instructionIdentification": "$OB-400-DOP-101600-instructionIdentification",
"endToEndIdentification": "e2e-internat-pay",
"postData": "$minimalInternationalPayment",
"postData": "$minimalInternationalPaymentV4",
"consentId": "$OB-400-DOP-101600-ConsentId"
},
"headers": {
Expand Down Expand Up @@ -725,7 +704,7 @@
"OB-400-DOP-102000-instructionIdentification": "$instructionIdentification",
"instructionIdentification": "$fn:instructionIdentificationID()",
"endToEndIdentification": "e2e-internat-sched-pay",
"postData": "$minimalInternationalScheduledPaymentConsent",
"postData": "$minimalInternationalScheduledPaymentConsentV4",
"requestConsent": "true"
},
"body": "$postData",
Expand Down Expand Up @@ -777,7 +756,7 @@
"currencyOfTransfer": "$currencyOfTransfer",
"instructionIdentification": "$OB-400-DOP-102000-instructionIdentification",
"endToEndIdentification": "e2e-internat-sched-pay",
"postData": "$minimalInternationalScheduledPayment",
"postData": "$minimalInternationalScheduledPaymentV4",
"consentId": "$OB-400-DOP-102000-ConsentId"
},
"headers": {
Expand Down