Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.1.8 VRPs - Java codegen results in missing headers and request body #51

Open
matt-wills opened this issue Jun 7, 2021 · 1 comment
Open

v3.1.8 VRPs - Java codegen results in missing headers and request body #51

matt-wills opened this issue Jun 7, 2021 · 1 comment

Comments

@matt-wills
Copy link

Up until now, I have generated the Java controllers and interfaces for all versions of the Read/Write API since v3.1.3, using the OpenAPI Maven plugin (openapi-generator-maven-plugin version 4.3.1). However, when generating the VRP controllers for v3.1.8, I don't seem to have any headers or request body objects in the generated code.

The response definitions appear correct, but it looks like there are no request parameters in the Swagger spec. Does anyone know why this is?
matt-wills added a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Jun 8, 2021
@matt-wills
36: Initial controllers and their interfaces for VRPs
ffb7737 
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct.
- I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51
- As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g.  the scopes) may not be correct.

Issue: OpenBankingToolkit/openbanking-toolkit#36
@matt-wills matt-wills mentioned this issue Jun 8, 2021
Closed
matt-wills added a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Jun 8, 2021
@matt-wills
36: Initial controllers and their interfaces for VRPs
3f8f240 
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct.
- I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51
- As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g.  the scopes) may not be correct.

Issue: OpenBankingToolkit/openbanking-toolkit#36
matt-wills added a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Jun 8, 2021
@matt-wills
36: Initial controllers and their interfaces for VRPs
05139a1 
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct.
- I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51
- As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g.  the scopes) may not be correct.

Issue: OpenBankingToolkit/openbanking-toolkit#36
@blockdor
Copy link

hi matt, just generated using same plugin
i got an error initially due to a repeat operationID, i amended to

/domestic-vrps/:consentId/payment-details:
get:
operationId: domesticVrpGetDetails

Seems to work now. I'm also using v5.1 of the plugin so maybe that will solve the problem,
org.openapitools
openapi-generator-maven-plugin
5.1.0

BohoCode pushed a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Nov 26, 2021
@matt-wills @BohoCode
36: Initial controllers and their interfaces for VRPs
cc8df31 
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct.
- I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51
- As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g.  the scopes) may not be correct.

Issue: OpenBankingToolkit/openbanking-toolkit#36
BohoCode pushed a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Nov 26, 2021
@matt-wills @BohoCode
36: Initial controllers and their interfaces for VRPs
38b14cb 
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct.
- I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51
- As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g.  the scopes) may not be correct.

Issue: OpenBankingToolkit/openbanking-toolkit#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blockdor @matt-wills