DO NOT MERGE - 36: Initial controllers and their interfaces for VRPs #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-wills
changed the title
jsanhc
approved these changes
Jun 8, 2021
matt-wills
force-pushed
the
feature/36-initial-vrp-controllers
branch
2 times, most recently
from
3f8f240
to
05139a1
Compare
BohoCode
reviewed
Jun 8, 2021
| nickname = "domesticVrpConsentsConsentIdFundsConfirmationPost", | ||
| notes = "create a domestic vrp", | ||
| response = Object.class, | ||
| // authorizations = { |
There was a problem hiding this comment.
Why are all the authorization's commented out?
There was a problem hiding this comment.
Because I don't know if they're correct. I mentioned "I have inserted them in commented out sections, but certain things (e.g. the scopes) may not be correct" in the description above.
|
Try model regeneration again as there have been subsequent releases of 3.1.8 including recent changes and fixes. Which indicates that the models should generate OK. Latest 3.1.8 tag is here; |
Some changes to VRP and Funds Conformation Issue: OpenBankingToolkit/openbanking-toolkit#45
- Fix simbols - Fix Shortcuts annotations in VRP controller interfaces Issue: OpenBankingToolkit/openbanking-toolkit#47
- Fix VRP request Mapping controllers annotation Issue: OpenBankingToolkit/openbanking-toolkit#47
BohoCode
force-pushed
the
feature/36-initial-vrp-controllers
branch
from
05139a1
to
cc8df31
Compare
- There are no request parameters in v3.1.8 of the VRP swagger spec, meaning the generated code did not have any request body objects or headers. I have added the request body objects manually, but they may not e correct. - I assume this is a mistake in the swagger spec and have created this issue: OpenBankingUK/read-write-api-specs#51 - As per other controllers in the Read/Write API, a number of annotations (e.g. @PreAuthorize and @OpenBankingAPI) need adding. I have inserted them in commented out sections, but certain things (e.g. the scopes) may not be correct. Issue: OpenBankingToolkit/openbanking-toolkit#36
For better comparison with the newly generated controllers in the feature/36-variable-recurring-payments-for-3-1-8 branch.
BohoCode
force-pushed
the
feature/36-initial-vrp-controllers
branch
from
45ea610
to
db14cf3
Compare
|
Closed, VRP payments has been implemented currently from v3.1.8 to v3.1.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial controllers and their interfaces for VRPs
@PreAuthorizeand@OpenBankingApi) need adding. I have inserted them in commented out sections, but certain things (e.g. the scopes) may not be correct.Issue: OpenBankingToolkit/openbanking-toolkit#36