refactor: using alertdialog versus popup

[clintonlunn]

---

name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''

---

What type of PR is this?(check all applicable)

• refactor
• feature
• bug fix
• documentation
• optimization
• other

Description

Related Issues

Issue #1145

What this PR achieves

Screenshots, recordings

Notes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
open-tacos	✅ Ready (Inspect)	Visit Preview	Sep 20, 2024 11:05pm

[clintonlunn]

@vnugent Looks like I might be getting the same errors as the last pr, preventing the preview from deploying. Not necessarily done with this pr or ready for review, but is there anything I can do to get the preview working?

[clintonlunn]

I wanted to give an alternative approach to using the alertdialog also. I was curious about how to make a custom control and also use the control positions.

[clintonlunn]

@vnugent sorry I kind of let this pr sit for several weeks. Do you have any input on using a custom control versus the AlertDialog component like we had originally discussed? I'm fine either way, I have always been curious about how to make a maplibre custom control, so I explored doing that.

in addition, I'm not sure why the preview is not working. I see the CI jobs are showing that docker-compose isn't found.

[vnugent]

I think you can use the existing AlertDialog. We should do UI cleanup/overhaul at some point.
The Vercel preview works for me. The docker-compose GitHub action may be broken. We can ignore it for now as long as Vercel build is green.

[clintonlunn]

@vnugent sounds good, I'll remove the custom control and use the AlertDialog component.

In addition, I can't promise a time commitment (it's about to be climbing season 😄), but I would like to be involved in the ui cleanup effort.

[vnugent]

@clintonlunn thanks for the fix. I did a quick test notice the picker doesn't set initial location based on the form state:

1. From the area edit page, click on the coordinates
2. Pick a different location. Click Confirm.
3. Click on the coordinate again. Notice how the drop pin is set at the original location, not at what we set in step 2.

I think the fix may be having initializing the drop pin (in a useEffect() to the value in the form state

[clintonlunn]

@clintonlunn thanks for the fix. I did a quick test notice the picker doesn't set initial location based on the form state:

1. From the area edit page, click on the coordinates
2. Pick a different location. Click Confirm.
3. Click on the coordinate again. Notice how the drop pin is set at the original location, not at what we set in step 2.

I think the fix may be having initializing the drop pin (in a useEffect() to the value in the form state

@vnugent
Thanks, that was it. Instead of passing an initialCenter prop to the coordinate map at all, we can just watch the form context for the latlngStr value and decide where to put the map pin.