Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IpInfo] Added extraction of asn data from org field #2911

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

annoyingapt
Copy link
Contributor

Proposed changes

  • Added elif to extract asn data from org field if using free plan.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Screenshot from free plan
Use ASN name: true
Screenshot 2024-11-05 134832

Use ASN name: false
Screenshot 2024-11-05 134814

Copy link

@twi252 twi252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works okay here, OpenCTI 6.3.11

@abdullahdevrel
Copy link

Hey guys, I just wanted to say thank you for bringing our (IPinfo's) data to the OpenCTI platform. Let me know if you need any help or anything.

@twi252
Copy link

twi252 commented Nov 14, 2024

@damians-filigran Hey Damian, was hoping we could have someone from Filigran to review please? Appreciate the help!

@damians-filigran
Copy link
Contributor

Hi @twi252, I'm not an approver. I'll forward to someone in @helene-nguyen 's team

@twi252
Copy link

twi252 commented Nov 15, 2024

Hi @twi252, I'm not an approver. I'll forward to someone in @helene-nguyen 's team

No worries, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants