Update JS dependencies #1190
Merged
Update JS dependencies #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
maintenance/upgrade-javascript-dependencies
branch
from
e449399
to
9250630
Compare
MKodde
force-pushed
the
maintenance/upgrade-javascript-dependencies
branch
from
9250630
to
5918919
Compare
Quite some JS dependencies had not been updated for some time. Leaving them vulnerable to security issues. Some of the packages have been upgraded to a couple of major releases higher than currently installed. This did not seem to have negative effect on the processes using the packages. But please be aware of this. For now only the socket.io and engine.io resolutions have been resolved.
MKodde
force-pushed
the
maintenance/upgrade-javascript-dependencies
branch
from
5918919
to
4811801
Compare
MKodde
force-pushed
the
maintenance/upgrade-javascript-dependencies
branch
3 times, most recently
from
cefdc77
to
2e030a2
Compare
After updating socket.io and engine.io, the snapshot plugin used by the cypress snapshot plugin no longer works. In order to run the tests we need the older (vulnerable) versions. And for passing security tests, we need the new version. (┛ಠ_ಠ)┛彡┻━┻ The current version of the snapshot project is not actively maintained, but the community is trying to take it over from the original maintainer. My suggestion is to keep it in the project for now, and hope for a speedy upgrade. If this is not the case we could look to use another plugin or disable the visual regression tests altogether? In my endeavours of jugling cypress plugins, I also took the liberty to update cypress to the latest version bumping it a whopping 4 major releases. Another sign of caution is raised here.. Tests seemed to run as before but we might experience BC breaking changes from the four version upgrades.
MKodde
force-pushed
the
maintenance/upgrade-javascript-dependencies
branch
from
2e030a2
to
becabc2
Compare
thijskh
approved these changes
May 5, 2022
VadimSchmitz
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security warnings where raised for two main reasons:
As a (temporal) solution. I chose to disable the conflicting snapshot plugin, and disable the visual regression tests that use them for now.
Read the commit messages for a bit more detail.