This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
ASM long -> 3 int transformation for light engine #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will probably be re-writing/simplifying a big portion of this soon. |
…lace and never used it
…ineAsm # Conflicts: # CubicChunksCore # src/main/java/io/github/opencubicchunks/cubicchunks/mixin/ASMConfigPlugin.java
CursedFlames
reviewed
Jul 2, 2023
There was a problem hiding this comment.
Don't see any major issues.
type-transformer-config-docs.mdstill needs to be finished- the transformer stuff could do with more comments/javadocs, of course; don't necessarily need this before merge though, it can be done later
- there's a bunch of things missing
@Nullablesince you useNonnullByDefault- I'm not gonna go through and comment on them all; it's pretty minor. - It might be worth chucking
List<Integer>[][]in a record class somewhere with a javadoc explaining what the indices actually do - I've read this entire PR and I'm still not sure what they are. - "indices" and "indexes" seem to be used inconsistently. Very minor
- can the int3 list/map/set/etc in
cubicchunks/utilsbe moved to cubicchunkscore?
To do before merge:
- Salamander addresses my comments
- Salamander finishes documentation in
type-transformer-config-docs.md - Would like others to carefully review the following:
- The int3 list/map/set stuff in
cubicchunks/utils TransformTrackingInterpeter.invokeDynamicOperationTypeTransformer.transformInvokeDynamicInsn
(I'm not confident enough in my knowledge of lambdas andinvokeDynamicin bytecode; I could have missed issues with the relevant methods.)
- The int3 list/map/set stuff in
- If possible, would like at least one other person to review this entire PR; I understand that reviewing 11k LoC diff is a big ask though 😅
buildSrc/src/main/java/io/github/opencubicchunks/gradle/TypeTransformConfigGen.java
Outdated
Show resolved
Hide resolved
| <module name="CyclomaticComplexity"> | ||
| <property name="switchBlockAsSingleDecisionPoint" value="true"/> | ||
| <property name="max" value="15"/> | ||
| <property name="tokens" value="LITERAL_WHILE , LITERAL_DO , LITERAL_FOR , LITERAL_IF , LITERAL_SWITCH , LITERAL_CASE , LITERAL_CATCH , QUESTION"/> |
There was a problem hiding this comment.
not sure of the consequences of this; would like others to review
src/main/java/io/github/opencubicchunks/cubicchunks/utils/Int3HashSet.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/utils/LinkedInt3HashSet.java
Outdated
Show resolved
Hide resolved
...hunks/mixin/transform/typetransformer/transformer/analysis/TransformTrackingInterpreter.java
Outdated
Show resolved
Hide resolved
...hunks/mixin/transform/typetransformer/transformer/analysis/TransformTrackingInterpreter.java
Outdated
Show resolved
Hide resolved
...opencubicchunks/cubicchunks/mixin/transform/typetransformer/transformer/TypeTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/mixin/transform/util/AncestorHashMap.java
Outdated
Show resolved
Hide resolved
|
|
||
| import org.objectweb.asm.Type; | ||
|
|
||
| public interface Ancestralizable<T extends Ancestralizable<T>> { |
There was a problem hiding this comment.
I feel like this could use a better name, but I don't have suggestions.
(Is "ancestralizable" even a word?)
|
Also another thing Salamander and I discussed that I forgot to mention here: For clarity, I think we should use |
rename static getKind to getKindFor in DerivedTransformType, as otherwise checkstyle complains about overloads that aren't together
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.