First draft of transport interfaces #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…following actions to use Node.js 20:" warnings
serges147
commented
Apr 4, 2024
serges147
commented
Apr 4, 2024
pavel-kirienko
requested changes
Apr 4, 2024
|
>Why the top header in the diagram does not have libcyphal as the first path component? |
pavel-kirienko
approved these changes
Apr 4, 2024
| virtual void run(const TimePoint now) = 0; | ||
|
|
||
| protected: | ||
| virtual ~IRunnable() = default; |
| NodeId max_nodes; | ||
| std::size_t mtu_bytes; | ||
| std::uint64_t transfer_id_modulo; | ||
|
|
There was a problem hiding this comment.
not to nitpick but I'm just curious are you adding the blank lines before the closing brace on purpose or is it a happy little accident
There was a problem hiding this comment.
Actually on purpose, like if I have in the end comment like this "}; // ProtocolParams" then I insert NL (new line) so that this comment and previous line don't "visually collapse".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
transport::ISessiontransport::IMessage[Rx|Ts]Sessiontransport::I[Request|Response][Rx|Ts]SessionAlso: