-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CETL VariableLengthArray and polymorphic_allocator #316
Conversation
You need to run Black to get the CI past the formatting errors. |
Updated my pull-request per the feedback. The ctor_convention approach and -std=cetl++ -std=c++17-pmr flags help simplify things and maintain better backward compatibility. The verification tests I added will fail due to CETL VLA not implementing the trailing-allocator convention correctly (I filed OpenCyphal/CETL#57 for that.) But I want to get this out for more feedback. |
5f93ac7
to
643625c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to specify the default memory resource that I'm missing?
f2ddf39
to
9b19f31
Compare
Kudos, SonarCloud Quality Gate passed! |
This change modifies the C++ code-gen to create message classes that can be used with allocators.