Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp: relocate the deprecated attribute to fix clang compilation (#299) #322

Merged

Conversation

beku-epitome
Copy link
Contributor

@beku-epitome beku-epitome commented Nov 3, 2023

Please review the syntax, I'm no Jinja expert. See #299 for explanation.

@beku-epitome beku-epitome force-pushed the bugfix/299-cpp-deprecated branch 2 times, most recently from 6e77404 to aa5b3b7 Compare November 3, 2023 10:30
Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the patch version also.

src/nunavut/lang/cpp/templates/_composite_type.j2 Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thirtytwobits thirtytwobits merged commit d9e0560 into OpenCyphal:main Nov 3, 2023
182 of 183 checks passed
@thirtytwobits
Copy link
Member

Thanks for the contribution @beku-epitome ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants