Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ParticipantBuiltInTopicData listener #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

e55k4y
Copy link

@e55k4y e55k4y commented Dec 9, 2017

DataListener implementation is done for ParticipantBuiltInTopic.
BuiltInTopic data parser is implemented, which generates UserDataQos and BuiltInTopicKey.
JS callback function is invoked on new participant.

@e55k4y
Copy link
Author

e55k4y commented Dec 11, 2017

The build failed in ./run-test.pl. But this error was not there when tested in local.

@mitza-oci
Copy link
Member

Which version of node are you using to test locally? We probably need to configure Travis CI to use the Node 6.x LTS version.

@e55k4y
Copy link
Author

e55k4y commented Dec 13, 2017

I used Node 8.x

@mitza-oci
Copy link
Member

Please try changing .travis.yml on your branch to have
node_js: "6"

https://docs.travis-ci.com/user/languages/javascript-with-nodejs/
We could try other versions too, so far we have used 6.x.

If you run multiple times on your local build, do any of them fail the same way that the Travis build did?

@e55k4y
Copy link
Author

e55k4y commented Dec 19, 2017

I forgot to unsubscribe to the ParticipantBuilTopicDataReader. That's why the process didn't exit properly and got a timeout error.
Checked that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants