Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typedef of TopicPort cvar #1503

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix typedef of TopicPort cvar #1503

merged 1 commit into from
Oct 23, 2023

Conversation

Cyberboss
Copy link
Contributor

@ike709
Copy link
Collaborator

ike709 commented Oct 20, 2023

PR should pass CI once you merge master (RT version got bumped).

@Cyberboss
Copy link
Contributor Author

Bro, I keep getting this error. No way it's from this change.

wixoaGit
wixoaGit approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@wixoaGit wixoaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raw logs don't show any obvious errors. I've tested this locally and it works, I'm going to merge this and see how it goes.

@wixoaGit wixoaGit enabled auto-merge (squash) October 23, 2023 14:08
@wixoaGit wixoaGit merged commit 17d0137 into OpenDreamProject:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cyberboss @ike709 @wixoaGit