Reduce compiler allocations #1530

wixoaGit · 2023-11-06T02:37:49Z

Does a few things:

Turn Token into a struct
Cache a StringBuilder in DMPreprocessorLexer and DMLexer
Turn DMVisitorExpression into a static DMExpressionBuilder class

Reduces the compiler's allocations on /tg/ from 3.9GB to 2.5GB.

It's not necessary to be creating a new one for every token that uses it Can't do this in `LexString()` unfortunately because it has a nested `NextToken()` call

Not a DMASTVisitor Static class, doesn't need to be instantiated/allocated every time it's used

wixoaGit added 8 commits November 5, 2023 18:03

Make tokens a struct instead of a class

1c02ad8

Cache a StringBuilder in DMPreprocessorLexer

520ccfb

It's not necessary to be creating a new one for every token that uses it Can't do this in `LexString()` unfortunately because it has a nested `NextToken()` call

Use a file-scoped namespace in DMVisitorExpression.cs

7de4ede

Turn DMVisitorExpression into DMExpressionBuilder

69b58ea

Not a DMASTVisitor Static class, doesn't need to be instantiated/allocated every time it's used

Fix some inferred paths

4e978b1

Make the cached StringBuilder readonly

e3b3534

Cache a StringBuilder in DMLexer

0a7f537

Use a file-scoped namespace in DMLexer.cs

5836d1e

wixoaGit merged commit 03fcfcb into OpenDreamProject:master Nov 8, 2023
4 checks passed

wixoaGit deleted the reduce_compiler_allocations branch November 8, 2023 20:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce compiler allocations #1530

Reduce compiler allocations #1530

wixoaGit commented Nov 6, 2023 •

edited

Loading

Reduce compiler allocations #1530

Reduce compiler allocations #1530

Conversation

wixoaGit commented Nov 6, 2023 • edited Loading

wixoaGit commented Nov 6, 2023 •

edited

Loading