Basic Maptext #2108
Basic Maptext #2108
Conversation
boring-cyborg
bot
added
Client
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| @@ -323,11 +325,9 @@ | |||
| _animatedAppearance.IconState = endAppearance.IconState; | |||
| if (endAppearance.Invisibility != _appearance.Invisibility) | |||
| _animatedAppearance.Invisibility = endAppearance.Invisibility; | |||
| if (endAppearance.Maptext != _appearance.Maptext) | |||
Check warning
Code scanning / InspectCode
Redundant condition check before assignments Warning
| @@ -227,6 +237,9 @@ | |||
| hashCode.Add(RenderTarget); | |||
| hashCode.Add(BlendMode); | |||
| hashCode.Add(AppearanceFlags); | |||
| hashCode.Add(Maptext); | |||
Check warning
Code scanning / InspectCode
Non-readonly type member referenced in 'GetHashCode()' Warning
| @@ -227,6 +237,9 @@ | |||
| hashCode.Add(RenderTarget); | |||
| hashCode.Add(BlendMode); | |||
| hashCode.Add(AppearanceFlags); | |||
| hashCode.Add(Maptext); | |||
| hashCode.Add(MaptextOffset); | |||
Check warning
Code scanning / InspectCode
Non-readonly type member referenced in 'GetHashCode()' Warning
| @@ -227,6 +237,9 @@ | |||
| hashCode.Add(RenderTarget); | |||
| hashCode.Add(BlendMode); | |||
| hashCode.Add(AppearanceFlags); | |||
| hashCode.Add(Maptext); | |||
| hashCode.Add(MaptextOffset); | |||
| hashCode.Add(MaptextSize); | |||
Check warning
Code scanning / InspectCode
Non-readonly type member referenced in 'GetHashCode()' Warning
| } | ||
|
|
||
|
|
||
| if (MaptextSize != MutableAppearance.Default.MaptextSize) { |
Check warning
Code scanning / InspectCode
Incorrect blank lines: Blank lines are redundant elsewhere Warning
| @@ -252,6 +261,9 @@ | |||
| hashCode.Add(RenderTarget); | |||
| hashCode.Add(BlendMode); | |||
| hashCode.Add(AppearanceFlags); | |||
| hashCode.Add(Maptext); | |||
Check warning
Code scanning / InspectCode
Non-readonly type member referenced in 'GetHashCode()' Warning
| @@ -252,6 +261,9 @@ | |||
| hashCode.Add(RenderTarget); | |||
| hashCode.Add(BlendMode); | |||
| hashCode.Add(AppearanceFlags); | |||
| hashCode.Add(Maptext); | |||
| hashCode.Add(MaptextOffset); | |||
Check warning
Code scanning / InspectCode
Non-readonly type member referenced in 'GetHashCode()' Warning
| @@ -252,6 +261,9 @@ | |||
| hashCode.Add(RenderTarget); | |||
| hashCode.Add(BlendMode); | |||
| hashCode.Add(AppearanceFlags); | |||
| hashCode.Add(Maptext); | |||
| hashCode.Add(MaptextOffset); | |||
| hashCode.Add(MaptextSize); | |||
Check warning
Code scanning / InspectCode
Non-readonly type member referenced in 'GetHashCode()' Warning
Rudimentary implementation. No tag processing but it shouldn't be too hard to add (just copying richtext formatting stuff)
Maptext inherits filters and transforms from parent atom.
Resolves #176