Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracy #2127

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Merge branch 'master' into tracy

27c1291
Select commit
Loading
Failed to load commit list.
Open

Tracy #2127

Merge branch 'master' into tracy
27c1291
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / InspectCode succeeded Jan 5, 2025 in 3s

4 new alerts

New alerts in code changed by this pull request

  • 3 warnings
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 21 in OpenDreamRuntime/Objects/DreamObject.cs

See this annotation in the file changed.

Code scanning / InspectCode

Inconsistent Naming Warning

Name '_tracyMemoryId' does not match rule 'Instance fields (not private)'. Suggested name is 'TracyMemoryId'.

Check warning on line 69 in OpenDreamRuntime/Profile.cs

See this annotation in the file changed.

Code scanning / InspectCode

Return type of a function can be made non-nullable Warning

Return type of 'BeginMemoryZone' can be made non-nullable

Check warning on line 24 in OpenDreamRuntime/Resources/DreamResource.cs

See this annotation in the file changed.

Code scanning / InspectCode

Non-accessed field: Private accessibility Warning

Field '_tracyMemoryId' is assigned but its value is never used

Check notice on line 29 in OpenDreamRuntime/Resources/DreamResource.cs

See this annotation in the file changed.

Code scanning / InspectCode

Merge conditional ?: expression into conditional access Note

Merge conditional expression

Check notice on line 8 in OpenDreamShared/OpenDreamCVars.cs

See this annotation in the file changed.

Code scanning / InspectCode

Replace built-in type reference with a CLR type name or a keyword in static member access expressions Note

Built-in type reference is inconsistent with code style settings