Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missed RenderTargetPool return #2180

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Fix a missed RenderTargetPool return #2180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4584e50
Fix a missed RenderTargetPool return
wixoaGit Jan 23, 2025
1337178
Move comment
wixoaGit Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions OpenDreamClient/Rendering/DreamIcon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,13 @@ public void Dispose() {
TextureRenderOffset = Vector2.Zero;
return frame;
} else {
if(textureOverride is not null)
return FullRenderTexture(viewOverlay, handle, iconMetaData, frame).Texture; //no caching in the presence of overrides
if (textureOverride is not null) { //no caching in the presence of overrides
var texture = FullRenderTexture(viewOverlay, handle, iconMetaData, frame);

renderTargetPool.ReturnAtEndOfFrame(texture);
return texture.Texture;
}

CachedTexture = FullRenderTexture(viewOverlay, handle, iconMetaData, frame);
}

Expand Down
Loading