Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin discard button 1326 #1330

Merged

Conversation

williamw04
Copy link
Contributor

Description

There was a desire to add a discard button in admin settings to unwanted changes

Fixes #1326

I added a discard button that reverts the admin preferences to default and I put this button and the submit button into a flex box for organization purposes.

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • [x} I have followed the OED pull request ideas
  • [x} I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

No extra work needs to be done

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @williamw04 for addressing this issue. Overall the code is fine and it works as expected. I have one small issue/comment to address.

src/client/app/components/admin/PreferencesComponent.tsx Outdated Show resolved Hide resolved
@huss huss merged commit 8a54247 into OpenEnergyDashboard:development Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nice to have: Discard button in admin settings
2 participants