Completed Test BG10 #1350
Merged
Completed Test BG10 #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huss
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks to @shankarp05 for their first pull request. Review found the code works as expected. I made a couple of minor comments about non-code lines that should be easy to address. Please let me know if you have any questions.
huss
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Thanks to @shankarp05 for addressing all the comments. Everything looks good. Congratulations on another merged contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented Test BG10 in readingsBarGroupQuantity.js
Added file expected_bar_group_ri_15-20_mu_kWh_gu_BTU_st_-inf_et_inf_bd_1.csv
Partly Addresses #962
Type of change
Checklist
Limitations
N/A