Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test BG11 #1359

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Test BG11 #1359

merged 5 commits into from
Oct 22, 2024

Conversation

aravindb24
Copy link
Contributor

@aravindb24 aravindb24 commented Oct 15, 2024

Wrote the test for BG11 which it passes successfully.

Fixes #962 (test: BG11)

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the [OED pull request] ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the [OED Contributing License Agreement and each author is listed in the Description section.

Limitations

No limitations

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @aravindb24 for their first contribution. Review and testing found one item to address. Please see the comment.

src/server/test/web/readingsBarGroupQuantity.js Outdated Show resolved Hide resolved
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @aravindb24 for the change. Review and testing found it works as expected. Congratulations on what I think is your first accepted contribution.

@huss huss merged commit edd58ae into OpenEnergyDashboard:development Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing readings
2 participants