Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a key to make fields (columns) nullable #161

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Oct 15, 2024

Summary of the discussion

To describe the table schema in the resource field, we need to add an option for nullable fields. As the schema field is also used for SQL table definitions, the nullable constraint is mandatory.

Type of change (CHANGELOG.md)

Added

  • Add key nullable to fields section (columns) (#161)

Workflow checklist

Automation

Closes #96
Closes #123

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature labels Oct 15, 2024
@Ludee Ludee requested a review from jh-RLI October 15, 2024 12:16
@Ludee Ludee self-assigned this Oct 15, 2024
@Ludee Ludee marked this pull request as ready for review October 15, 2024 12:22
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jh-RLI jh-RLI merged commit 8f8ff90 into develop Oct 15, 2024
2 checks passed
@Ludee Ludee deleted the feature-96-nullable-fields branch October 16, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature
Projects
Status: Done
2 participants