Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix #482 - Change data types #483

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Hotfix #482 - Change data types #483

merged 3 commits into from
Jan 17, 2024

Conversation

FlorianK13
Copy link
Member

@FlorianK13 FlorianK13 commented Jan 17, 2024 •
edited
Loading

Automation

Closes #482

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@FlorianK13 FlorianK13 linked an issue Jan 17, 2024 that may be closed by this pull request
VALUE ERROR when creating Table after gas_producer Table #482
Closed
1 task
@FlorianK13 FlorianK13 marked this pull request as ready for review January 17, 2024 11:31
@FlorianK13 FlorianK13 requested a review from chrwm January 17, 2024 11:31
@FlorianK13
Copy link
Member Author

@chrwm This is not yet ready to merge, as it will also be the release branch for 0.14.1

@chrwm
Copy link
Member

chrwm commented Jan 17, 2024

So, I should wait with the review?

chrwm
chrwm approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@chrwm chrwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix!

@FlorianK13 FlorianK13 merged commit bfa686f into production Jan 17, 2024
6 checks passed
@nesnoj nesnoj mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrwm chrwm chrwm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VALUE ERROR when creating Table after gas_producer Table
2 participants
@FlorianK13 @chrwm