MHK: add parameters for readability #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I don't really like these parameters in NWTC Library, but they seem to be used in many different modules, so that's the easiest place for now - some of the IF statements had redundant ELSEIF instead of just ELSE, so I simplified them from (IF A ... ELSEIF NOT A...) to (IF A ... ELSE...)
andrew-platt
approved these changes
Jun 15, 2023
|
@hkross, do you want to take a quick look? |
|
Thanks for doing this, @bjonkman! The MHK flag is used in a couple of places in AeroDyn_Driver_Subs as well. Would you prefer to change these to parameters or leave them as flags for the driver? |
|
I think it makes sense to change the AeroDyn_Driver_Subs.f90 as well. |
|
AD driver has been updated as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR is for code readability.
MHK=={0|1|2}statements using parameters for the 3 allowed values of MHK. I am not thrilled with putting the MHK parameters in NWTC Library, but they are used in many different modules so that's where I put them (at least for now).IF (A) THEN ... ELSEIF (NOT A)statements are nowIF (A) THEN... ELSE, avoiding a second check that must always be true.Related issue, if one exists
None.
Impacted areas of the software
This impacts the places that check the value of the
MHKvariable: ElastoDyn, AeroDyn, InflowWind, and OpenFAST glue codeAdditional supporting information
Test results, if applicable
This shouldn't affect any tests. Tests have have failed are related to GH Actions getting the wrong patch version of python.